• freamon@preferred.social
    link
    fedilink
    English
    arrow-up
    3
    ·
    5 days ago

    I’ll just remove the ‘freamon’ one when the auto-generated one is up to date.

    The manually-generated one had 5 missing routes, which I’ve since added.

    The auto-generated one at crust has about 48 missing routes. It’s the right approach, and I’ll help out with it when I can, but - for now at least - it makes no sense to redirect people to it (either automatically or via a comment).


    Some thoughts for @[email protected]

    /site/instance_chooser probably doesn’t need to be a route. It’s just the data format returned by /site/instance_chooser_search. As a route, it’s returning the instance info for the site you’re querying, so if you want to keep it as a route, it should probably be called /site/instance_info or something.

    In the query for /site/instance_chooser_search, nsfw and newbie are both booleans. With the rest of the API, these are sent as ‘true’ or ‘false’, but they are ‘yes’ and ‘no’ for this route. The newbie query should probably be newbie_friendly In the response, monthsmonitored should probably be months_monitored

    There’s no way to exclude communities for the response to /topic/list and /feed/list: If you don’t put ‘include_communities’ in the query, it’s defaults to True, but if you put ‘include_communities=false’ in the query it ends up being True also (because the word ‘include_communities’ is in the data).

    • wjs018@piefed.social
      link
      fedilink
      English
      arrow-up
      3
      ·
      5 days ago

      TIL that rimu added instance chooser endpoints. I’ll take a look at those before 1.2 gets shipped. Same with the topic and feed endpoints. The easiest time to make changes to them is now before they get more widely used.

      I have about 10 more endpoints (working through /user right now) I have finished transitioning in a dev branch right now, so we are making progress.