• z3bra@lemmy.sdf.org
    link
    fedilink
    arrow-up
    7
    arrow-down
    1
    ·
    edit-2
    1 year ago

    When I talk about alignment it’s not about function arguments, but values, “=” signs and such. You simply cannot use tabs for that because alignment must be fixed and indentation independent:

    CreateOrderRequest(
        user,
        productDetails     => order.detail,
        pricingCalculator  => DEFAULT_CALCULATOR,
        order              => order.internalNumber)
    
    • realharo@lemm.ee
      link
      fedilink
      arrow-up
      10
      ·
      edit-2
      1 year ago

      I normally avoid that too, I find it hurts readability more than helps, plus a proper IDE will separate it with color anyway.

      But yeah, the newline comment doesn’t apply to this.

      • z3bra@lemmy.sdf.org
        link
        fedilink
        arrow-up
        1
        ·
        1 year ago

        To each their own indeed. But my rule of thumb is: only use tabs when there’s no other character before it (aka, start of line).

    • PHLAK@lemmy.world
      link
      fedilink
      English
      arrow-up
      6
      ·
      1 year ago

      This kind of “manual” alignment should be avoided for many reasons including the fact that adding/removing/changing of one parameter here may force you to modify multiple lines which on it’s own is annoying but this will also show up in the diff during review making it harder to grep what was actually changed.

      • z3bra@lemmy.sdf.org
        link
        fedilink
        arrow-up
        2
        ·
        1 year ago

        I personally favor code readability over patch readability. But I reckon this is a matter of preference so I can understand how you might not like that.

    • catastrophicblues@lemmy.ca
      link
      fedilink
      arrow-up
      4
      ·
      1 year ago

      Yeah I agree I don’t find alignment very useful. It’s more work for dubious benefit, and god forbid you change one of the lines.